github-actions[bot] commented on code in PR #28082:
URL: https://github.com/apache/doris/pull/28082#discussion_r1555644843
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -751,6 +751,16 @@ Version TabletMeta::max_version() const {
return max_version;
}
+size_t TabletMeta::version_count_cross_with_range(const Version& range) const {
+ size_t count = 0;
+ for (const auto& rs_meta : _rs_metas) {
+ if (!(range.first > rs_meta->version().second || range.second <
rs_meta->version().first)) {
+ count++;
+ }
+ }
Review Comment:
warning: method 'add_rs_meta' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/tablet_meta.h:182:
```diff
- Status add_rs_meta(const RowsetMetaSharedPtr& rs_meta);
+ static Status add_rs_meta(const RowsetMetaSharedPtr& rs_meta);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
