caiconghui commented on a change in pull request #7371:
URL: https://github.com/apache/incubator-doris/pull/7371#discussion_r766568467
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -582,14 +580,19 @@ private Catalog(boolean isCheckpointCatalog) {
this.tabletScheduler = new TabletScheduler(this, systemInfo,
tabletInvertedIndex, stat, Config.tablet_rebalancer_type);
this.tabletChecker = new TabletChecker(this, systemInfo,
tabletScheduler, stat);
+ // The pendingLoadTaskScheduler's queue size should not less than
Config.desired_max_waiting_jobs.
+ // So that we can guarantee that all submitted load jobs can be
scheduled without being starved.
this.pendingLoadTaskScheduler = new
MasterTaskExecutor("pending_load_task_scheduler",
Config.async_pending_load_task_pool_size,
- Config.async_pending_load_task_pool_size,
!isCheckpointCatalog);
+ Config.desired_max_waiting_jobs, !isCheckpointCatalog);
+ // The loadingLoadTaskScheduler's queue size is unlimited, so that it
can receive all loading tasks
+ // created after pending tasks finish. And don't worry about the high
concurrency, because the
Review comment:
pending task cost less time than loading task. so my idea is that if
load task thread pool is full, not submit task of not started job, for that
once start job and still no resource to execute loading task, the job will wait
to be timeout, not because of slow running but absent of thread resource.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
