github-actions[bot] commented on code in PR #33446:
URL: https://github.com/apache/doris/pull/33446#discussion_r1557735081
##########
be/src/vec/sink/writer/vhive_partition_writer.cpp:
##########
@@ -135,17 +136,18 @@ Status VHivePartitionWriter::open(RuntimeState* state,
RuntimeProfile* profile)
}
}
-Status VHivePartitionWriter::close(Status status) {
- if (_vfile_writer != nullptr) {
- Status st = _vfile_writer->close();
- if (st != Status::OK()) {
- LOG(WARNING) << fmt::format("_vfile_writer close failed, reason:
{}", st.to_string());
+Status VHivePartitionWriter::close(const Status& status) {
Review Comment:
warning: method 'close' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/writer/vhive_partition_writer.h:58:
```diff
- Status close(const Status& status);
+ static Status close(const Status& status);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
