platoneko commented on code in PR #33387:
URL: https://github.com/apache/doris/pull/33387#discussion_r1558733824
##########
be/src/olap/schema_change.cpp:
##########
@@ -1296,6 +1296,17 @@ Status SchemaChangeJob::parse_request(const
SchemaChangeParams& sc_params,
if (column_mapping->expr != nullptr) {
*sc_directly = true;
return Status::OK();
+ } else if (column_mapping->ref_column >= 0) {
+ auto column_new = new_tablet_schema->column(i);
+ auto column_old =
base_tablet_schema->column(column_mapping->ref_column);
Review Comment:
```suggestion
const auto& column_old =
base_tablet_schema->column(column_mapping->ref_column);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
