xiaokang commented on code in PR #33480:
URL: https://github.com/apache/doris/pull/33480#discussion_r1560421164
##########
be/src/olap/tablet.cpp:
##########
@@ -1641,10 +1641,11 @@ void
Tablet::execute_single_replica_compaction(SingleReplicaCompaction& compacti
std::vector<Version> Tablet::get_all_versions() {
std::vector<Version> local_versions;
{
- std::lock_guard<std::shared_mutex> wrlock(_meta_lock);
- SCOPED_SIMPLE_TRACE_IF_TIMEOUT(TRACE_TABLET_LOCK_THRESHOLD);
- for (const auto& it : _rs_version_map) {
- local_versions.emplace_back(it.first);
+ std::shared_lock rlock(_meta_lock);
+ for (const auto& [version, rs] : _rs_version_map) {
+ if (rs->is_local()) {
Review Comment:
add comment to explain why only add local rowset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
