LiBinfeng-01 commented on code in PR #33517:
URL: https://github.com/apache/doris/pull/33517#discussion_r1561084603
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/hint/LeadingHint.java:
##########
@@ -287,12 +287,16 @@ public Long getTotalBitmap() {
/**
* set total bitmap used in leading before we get into leading join
*/
- public void setTotalBitmap() {
+ public void setTotalBitmap(Set<RelationId> inputRelationSets) {
Long totalBitmap = 0L;
if (hasSameName()) {
this.setStatus(HintStatus.SYNTAX_ERROR);
this.setErrorMessage("duplicated table");
}
+ if (getTablelist().size() < inputRelationSets.size()) {
+ this.setStatus(HintStatus.SYNTAX_ERROR);
+ this.setErrorMessage("leading should have all tables in query
block");
Review Comment:
done
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/hint/LeadingHint.java:
##########
@@ -287,12 +287,16 @@ public Long getTotalBitmap() {
/**
* set total bitmap used in leading before we get into leading join
*/
- public void setTotalBitmap() {
+ public void setTotalBitmap(Set<RelationId> inputRelationSets) {
Long totalBitmap = 0L;
if (hasSameName()) {
this.setStatus(HintStatus.SYNTAX_ERROR);
this.setErrorMessage("duplicated table");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
