HappenLee commented on code in PR #33634:
URL: https://github.com/apache/doris/pull/33634#discussion_r1564634000
##########
be/src/vec/functions/functions_logical.h:
##########
@@ -94,6 +94,18 @@ struct OrImpl {
static inline constexpr bool special_implementation_for_nulls() { return
true; }
};
+struct XorImpl {
+ using ResultType = UInt8;
+
+ static inline constexpr ResultType apply(UInt8 a, UInt8 b) { return a ^ b;
}
+ // select null xor true , null xor false , false xor null , true xor null
;
+ // null null null null
+ static inline constexpr ResultType apply_null(UInt8 a, UInt8 l_null, UInt8
b, UInt8 r_null) {
+ return l_null or r_null;
+ }
+ static inline constexpr bool special_implementation_for_nulls() { return
true; }
Review Comment:
maybe should be `false` and not need impl the `apply_null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
