github-actions[bot] commented on code in PR #33665:
URL: https://github.com/apache/doris/pull/33665#discussion_r1565468806
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -2677,5 +2680,21 @@ bool SegmentIterator::_has_delete_predicate(ColumnId
cid) {
return delete_columns_set.contains(cid);
}
+bool SegmentIterator::_can_opt_topn_reads() const {
+ if (_opts.topn_limit <= 0) {
Review Comment:
warning: method '_can_opt_topn_reads' can be made static
[readability-convert-member-functions-to-static]
```suggestion
{
```
be/src/olap/rowset/segment_v2/segment_iterator.h:382:
```diff
- bool _can_opt_topn_reads() const;
+ static bool _can_opt_topn_reads() ;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
