github-actions[bot] commented on code in PR #33691:
URL: https://github.com/apache/doris/pull/33691#discussion_r1566658252
##########
be/src/vec/common/pod_array_fwd.h:
##########
@@ -28,26 +28,33 @@
namespace doris::vectorized {
-inline constexpr size_t integerRoundUp(size_t value, size_t dividend) {
+inline constexpr size_t integer_round_up(size_t value, size_t dividend) {
return ((value + dividend - 1) / dividend) * dividend;
}
+inline constexpr size_t max_right_padding(size_t element_size, size_t
PADDING_SIMD_SIZE = 16) {
+ if (element_size > PADDING_SIMD_SIZE) {
+ return max_right_padding(element_size % PADDING_SIMD_SIZE,
PADDING_SIMD_SIZE);
+ } else {
+ return PADDING_SIMD_SIZE - std::gcd(element_size, PADDING_SIMD_SIZE);
Review Comment:
warning: no member named 'gcd' in namespace 'std' [clang-diagnostic-error]
```cpp
return PADDING_SIMD_SIZE - std::gcd(element_size, PADDING_SIMD_SIZE);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
