github-actions[bot] commented on code in PR #33511:
URL: https://github.com/apache/doris/pull/33511#discussion_r1567628751
##########
be/src/vec/core/sort_block.h:
##########
@@ -223,6 +223,15 @@ class ColumnSorter {
}
}
+ void sort_column(const ColumnString64& column, EqualFlags& flags,
IColumn::Permutation& perms,
+ EqualRange& range, bool last_column) const {
Review Comment:
warning: method 'sort_column' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void sort_column(const ColumnString64& column, EqualFlags& flags,
IColumn::Permutation& perms,
EqualRange& range, bool last_column) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
