yiguolei commented on code in PR #33747:
URL: https://github.com/apache/doris/pull/33747#discussion_r1568340972
##########
be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp:
##########
@@ -45,8 +45,21 @@ Status
PartitionedHashJoinSinkLocalState::init(doris::RuntimeState* state,
Status PartitionedHashJoinSinkLocalState::open(RuntimeState* state) {
RETURN_IF_ERROR(PipelineXSpillSinkLocalState::open(state));
+ auto& p = _parent->cast<PartitionedHashJoinSinkOperatorX>();
Review Comment:
我们不一定落盘，但是在这里去register 可能会导致有一些overhead？ 我看这里面会访问一些disk store
这些。这个逻辑能否延迟到，第一次spill的时候？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
