starocean999 commented on code in PR #33774:
URL: https://github.com/apache/doris/pull/33774#discussion_r1568528216
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java:
##########
@@ -806,7 +806,7 @@ private Plan
bindSortWithoutSetOperation(MatchingContext<LogicalSort<Plan>> ctx)
/**
* For the columns whose output exists in grouping sets, they need to be
assigned as nullable.
*/
- private List<NamedExpression> adjustNullableForRepeat(
+ public static List<NamedExpression> adjustNullableForRepeat(
Review Comment:
better to move the method into PlanUtils.java, if it's used in two rules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
