This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git
commit e9eccb08a5ac9be4c30120d64aa7bb5676650770 Author: jakevin <[email protected]> AuthorDate: Wed Apr 17 18:35:48 2024 +0800 [minor](Nereids): remove useless stream filter() in Translator (#33758) --- .../doris/nereids/glue/translator/PhysicalPlanTranslator.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java index ab72d995573..8117d9122d1 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java @@ -1383,7 +1383,6 @@ public class PhysicalPlanTranslator extends DefaultPlanVisitor<PlanFragment, Pla hashJoin.getOtherJoinConjuncts() .stream() - .filter(e -> !(e.equals(BooleanLiteral.TRUE))) .flatMap(e -> e.getInputSlots().stream()) .map(SlotReference.class::cast) .forEach(s -> hashOutputSlotReferenceMap.put(s.getExprId(), s)); @@ -1525,11 +1524,10 @@ public class PhysicalPlanTranslator extends DefaultPlanVisitor<PlanFragment, Pla leftIntermediateSlotDescriptor.forEach(sd -> sd.setIsNullable(true)); } + // Constant expr will cause be crash. + // But EliminateJoinCondition and Expression Rewrite already eliminate true literal. List<Expr> otherJoinConjuncts = hashJoin.getOtherJoinConjuncts() .stream() - // TODO add constant expr will cause be crash, currently we only handle true literal. - // remove it after Nereids could ensure no constant expr in other join condition - .filter(e -> !(e.equals(BooleanLiteral.TRUE))) .map(e -> ExpressionTranslator.translate(e, context)) .collect(Collectors.toList()); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
