This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-4.0-preview in repository https://gitbox.apache.org/repos/asf/doris.git
commit 1dceb89a03caaff61d4660736ca2476347fd44e6 Author: airborne12 <[email protected]> AuthorDate: Wed Apr 17 14:09:04 2024 +0800 [Fix](inverted index) fix memory leak when inverted index writer not close (#33724) --- be/src/olap/rowset/segment_v2/inverted_index_writer.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/be/src/olap/rowset/segment_v2/inverted_index_writer.cpp b/be/src/olap/rowset/segment_v2/inverted_index_writer.cpp index b77d5d6b324..e9956008f98 100644 --- a/be/src/olap/rowset/segment_v2/inverted_index_writer.cpp +++ b/be/src/olap/rowset/segment_v2/inverted_index_writer.cpp @@ -91,7 +91,11 @@ public: _field_name = std::wstring(field_name.begin(), field_name.end()); } - ~InvertedIndexColumnWriterImpl() override = default; + ~InvertedIndexColumnWriterImpl() override { + if (_index_writer != nullptr) { + close_on_error(); + } + } Status init() override { try { @@ -112,6 +116,7 @@ public: void close() { if (_index_writer) { _index_writer->close(); + _index_writer.reset(); } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
