gavinchou commented on code in PR #33802:
URL: https://github.com/apache/doris/pull/33802#discussion_r1568863164
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -201,8 +201,6 @@ BetaRowsetWriter::BetaRowsetWriter(StorageEngine& engine)
BaseBetaRowsetWriter::~BaseBetaRowsetWriter() {
// TODO(lingbin): Should wrapper exception logic, no need to know file ops
directly.
if (!_already_built) { // abnormal exit, remove all files generated
- WARN_IF_ERROR(_segment_creator.close(),
Review Comment:
we may need to check if the state of this writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
