github-actions[bot] commented on code in PR #33496:
URL: https://github.com/apache/doris/pull/33496#discussion_r1569954495
##########
be/src/pipeline/exec/scan_operator.cpp:
##########
@@ -164,7 +161,7 @@ Status ScanLocalState<Derived>::open(RuntimeState* state) {
}
template <typename Derived>
-Status ScanLocalState<Derived>::_normalize_conjuncts() {
+Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
Review Comment:
warning: function '_normalize_conjuncts' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/exec/scan_operator.cpp:163:** 100 lines including
whitespace and comments (threshold 80)
```cpp
Status ScanLocalState<Derived>::_normalize_conjuncts(RuntimeState* state) {
^
```
</details>
##########
be/src/pipeline/exec/olap_scan_operator.h:
##########
@@ -83,6 +83,8 @@ class OlapScanLocalState final : public
ScanLocalState<OlapScanLocalState> {
bool _storage_no_merge() override;
+ bool _push_down_topn() override { return true; }
Review Comment:
warning: method '_push_down_topn' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static bool _push_down_topn() override { return true; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
