EmmyMiao87 commented on a change in pull request #7448:
URL: https://github.com/apache/incubator-doris/pull/7448#discussion_r775839079
##########
File path: be/src/exprs/bloomfilter_predicate.h
##########
@@ -206,11 +206,12 @@ struct StringFindOp {
template <class BloomFilterAdaptor>
struct FixedStringFindOp : public StringFindOp<BloomFilterAdaptor> {
ALWAYS_INLINE bool find_olap_engine(const BloomFilterAdaptor& bloom_filter,
- const void* data) const {
- const auto* value = reinterpret_cast<const StringValue*>(data);
- auto end_ptr = value->ptr + value->len - 1;
- while (end_ptr > value->ptr && *end_ptr == '\0') --end_ptr;
- return bloom_filter.test_bytes(value->ptr, end_ptr - value->ptr + 1);
Review comment:
Because the size of the empty string is 1.
It is expected that the parameter passed into the function test_bytes should
be 0.
he previous logic cannot turn 1 into 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
