gavinchou commented on code in PR #33914:
URL: https://github.com/apache/doris/pull/33914#discussion_r1572523396
##########
cloud/src/meta-service/meta_service_helper.h:
##########
@@ -155,7 +155,7 @@ inline MetaServiceCode cast_as(TxnErrorCode code) {
finish_rpc(#func_name, ctrl, response);
\
closure_guard.reset(nullptr);
\
if (config::use_detailed_metrics && !instance_id.empty() &&
!drop_request) { \
- g_bvar_ms_##func_name.put(instance_id, sw.elapsed_us());
\
+ g_bvar_ms_##func_name.put(instance_id, sw.elapsed_us() / 1000);
\
Review Comment:
the word "ms" of "g_bvar_ms" is not the time unit, it is short for
meta-service.
we intend to use the time unit microsecond(us).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
