gavinchou commented on code in PR #33917:
URL: https://github.com/apache/doris/pull/33917#discussion_r1572635888
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -1969,4 +1969,119 @@ void
MetaServiceImpl::clean_txn_label(::google::protobuf::RpcController* control
code = MetaServiceCode::OK;
}
+void MetaServiceImpl::get_txn_id(::google::protobuf::RpcController* controller,
Review Comment:
Add sufficient comment to describe what does it do.
##########
gensrc/proto/cloud.proto:
##########
@@ -687,6 +687,18 @@ message GetTxnResponse {
optional TxnInfoPB txn_info = 2;
}
+message GetTxnIdRequest {
+ optional string cloud_unique_id = 1; // For auth
+ optional int64 db_id = 2;
+ optional string label = 3;
+ repeated TxnStatusPB status = 4;
+}
+
+message GetTxnIdResponse {
+ optional MetaServiceResponseStatus status = 1;
+ optional int64 txn_id = 2;
Review Comment:
repeated?
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
Review Comment:
pls add UT to cover all the newly added code: line/branch coverage 90+%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
