yiguolei commented on code in PR #33910:
URL: https://github.com/apache/doris/pull/33910#discussion_r1572704573
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadschedpolicy/WorkloadSchedPolicy.java:
##########
@@ -183,7 +183,11 @@ public void updateProperty(Map<String, String> property,
List<Long> wgIdList) {
this.priority = Integer.parseInt(priorityStr);
}
- if (wgIdList.size() > 0) {
+ String workloadGroupIdStr = property.get(WORKLOAD_GROUP);
+ // workloadGroupIdStr != null means user set workload group property,
+ // then we should overwrite policy's workloadGroupIdList
+ // if workloadGroupIdStr.length == 0, it means the policy should match
all query.
+ if (workloadGroupIdStr != null) {
Review Comment:
using strings.isnullorempty to check the value is null or empty, not only
check nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
