morningman commented on code in PR #33858:
URL: https://github.com/apache/doris/pull/33858#discussion_r1573297775
##########
regression-test/suites/load_p0/tvf/test_s3_tvf.groovy:
##########
@@ -140,20 +146,23 @@ suite("test_s3_tvf", "load_p0") {
attributeList.add(new TvfAttribute(table, ["k00", "k01", "k02", "k03",
"k04", "k05", "k06", "k07", "k08", "k09", "k10", "k11", "k12", "k13", "k14",
"k15", "k16", "k17", "k18"], "", "", true)
.addProperty("uri",
"s3://doris-build-1308700295.cos.ap-beijing.myqcloud.com/regression/load/data/basic_data_with_errors.csv")
.addProperty("format", "csv")
- .addProperty("column_separator", "|"))
+ .addProperty("column_separator", "|")
+ .addProperty("force_parsing_by_standard_uri", "true"))
Review Comment:
The default value of `force_parsing_by_standard_uri` is false.
So if we do this modification, user need to change their origin stmt?
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/S3TableValuedFunction.java:
##########
@@ -68,12 +66,17 @@ public S3TableValuedFunction(Map<String, String>
properties) throws AnalysisExce
forwardCompatibleDeprecatedKeys(otherProps);
String usePathStyle = getOrDefaultAndRemove(otherProps,
PropertyConverter.USE_PATH_STYLE, "false");
- boolean forceVirtualHosted = isVirtualHosted(uriStr,
Boolean.parseBoolean(usePathStyle));
- S3URI s3uri = getS3Uri(uriStr, forceVirtualHosted);
- String endpoint = forceVirtualHosted
- ? getEndpointAndSetVirtualBucket(s3uri, otherProps) :
s3uri.getBucketScheme();
+ String forceParsingByStandardUri = getOrDefaultAndRemove(otherProps,
Review Comment:
Define the default value of `forceParsingByStandardUri` and `usePathStyle`
somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
