github-actions[bot] commented on code in PR #33932:
URL: https://github.com/apache/doris/pull/33932#discussion_r1573492640
##########
be/src/vec/exec/format/parquet/parquet_column_convert.h:
##########
@@ -262,9 +280,9 @@ class FixedSizeBinaryConverter : public
PhysicalToLogicalConverter {
public:
FixedSizeBinaryConverter(int type_length) : _type_length(type_length) {}
- Status physical_convert(ColumnPtr& src_physical_col) override {
+ Status physical_convert(ColumnPtr& src_physical_col, ColumnPtr&
src_logical_column) override {
Review Comment:
warning: method 'physical_convert' can be made const
[readability-make-member-function-const]
```suggestion
Status physical_convert(ColumnPtr& src_physical_col, ColumnPtr&
src_logical_column) const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
