jackwener commented on a change in pull request #7557:
URL: https://github.com/apache/incubator-doris/pull/7557#discussion_r776950904



##########
File path: be/src/olap/bloom_filter_predicate.cpp
##########
@@ -34,6 +40,73 @@
     M(TYPE_STRING)
 
 namespace doris {
+
+// blomm filter column predicate do not support in segment v1

Review comment:
       Why put the template into cpp file instead of header file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to