morrySnow commented on code in PR #33642:
URL: https://github.com/apache/doris/pull/33642#discussion_r1574453982
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalUnion.java:
##########
@@ -196,6 +196,11 @@ public void computeUniform(FunctionalDependencies.Builder
fdBuilder) {
// don't propagate uniform slots
}
+ @Override
+ public void computeEqualSet(FunctionalDependencies.Builder fdBuilder) {
+ // don't generate any equal pair
Review Comment:
why?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAggregate.java:
##########
@@ -390,4 +390,9 @@ public ImmutableSet<FdItem> computeFdItems() {
return builder.build();
}
+
+ @Override
+ public void computeEqualSet(FunctionalDependencies.Builder fdBuilder) {
+
fdBuilder.addEqualSet(child().getLogicalProperties().getFunctionalDependencies());
Review Comment:
agg output not equal with its child, so just add is ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
