github-actions[bot] commented on code in PR #33980:
URL: https://github.com/apache/doris/pull/33980#discussion_r1574572629
##########
be/src/vec/sink/vresult_sink.h:
##########
@@ -141,6 +141,8 @@ class VResultSink : public DataSink {
const RowDescriptor& row_desc() { return _row_desc; }
+ bool isBinaryFormat() const { return _binary_row_format; }
Review Comment:
warning: function 'isBinaryFormat' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] bool isBinaryFormat() const { return _binary_row_format; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
