morningman commented on a change in pull request #7568:
URL: https://github.com/apache/incubator-doris/pull/7568#discussion_r777796598
##########
File path: extension/DataX/doriswriter/doc/doriswriter.md
##########
@@ -166,16 +166,10 @@ DorisWriter 通过Doris原生支持Stream load方式导入数据， DorisWriter
* **format**
- - 描述：导入数据的格式, 可以使是json或者csv。
+ - 描述：导入数据的格式, 目前支持json。
Review comment:
I think we can just delete this config.
##########
File path: extension/DataX/doriswriter/doc/doriswriter.md
##########
@@ -166,16 +166,10 @@ DorisWriter 通过Doris原生支持Stream load方式导入数据， DorisWriter
Review comment:
I think the default lineDelimiter can be `\x02\x03`?
So to avoid `\n` appeared in user's data.
##########
File path:
extension/DataX/doriswriter/src/main/java/com/alibaba/datax/plugin/writer/doriswriter/DorisJsonCodec.java
##########
@@ -46,5 +44,4 @@ public String serialize(final Record row) {
}
return JSON.toJSONString(rowMap);
}
-
-}
\ No newline at end of file
+}
Review comment:
We can create `final Map<String, Object> rowMap` in constructor of
`DorisJsonCodec` and reuse it in `serialize()`.
No need to create it for every row.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
