BiteTheDDDDt commented on code in PR #33167: URL: https://github.com/apache/doris/pull/33167#discussion_r1576040074
########## be/src/vec/aggregate_functions/aggregate_function_uniq_without_key.h: ########## @@ -0,0 +1,256 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// This file is copied from +// https://github.com/ClickHouse/ClickHouse/blob/master/src/AggregateFunctions/AggregateFunctionUniqDistributeKey.h +// and modified by Doris + +#pragma once + +#include <stddef.h> + +#include <algorithm> +#include <boost/iterator/iterator_facade.hpp> +#include <memory> +#include <vector> + +#include "vec/aggregate_functions/aggregate_function.h" +#include "vec/aggregate_functions/aggregate_function_uniq.h" +#include "vec/columns/column.h" +#include "vec/columns/column_fixed_length_object.h" +#include "vec/columns/column_nullable.h" +#include "vec/columns/column_vector.h" +#include "vec/columns/columns_number.h" +#include "vec/common/assert_cast.h" +#include "vec/core/types.h" +#include "vec/data_types/data_type.h" +#include "vec/data_types/data_type_fixed_length_object.h" +#include "vec/data_types/data_type_number.h" +#include "vec/io/var_int.h" + +namespace doris { +namespace vectorized { +class Arena; +class BufferReadable; +class BufferWritable; +} // namespace vectorized +} // namespace doris +template <typename T> +struct HashCRC32; +namespace doris::vectorized { + +template <typename T> +struct AggregateFunctionUniqDistributeKeyData { + static constexpr bool is_string_key = std::is_same_v<T, String>; + using Key = std::conditional_t<is_string_key, UInt128, T>; + using Hash = std::conditional_t<is_string_key, UInt128TrivialHash, HashCRC32<Key>>; + + using Set = flat_hash_set<Key, Hash>; + + // TODO: replace SipHash with xxhash to speed up + static UInt128 ALWAYS_INLINE get_key(const StringRef& value) { + UInt128 key; + SipHash hash; + hash.update(value.data, value.size); + hash.get128(key.low, key.high); + return key; + } + + Set set; + UInt64 count = 0; +}; + +template <typename T, typename Data> +class AggregateFunctionUniqDistributeKey final + : public IAggregateFunctionDataHelper<Data, AggregateFunctionUniqDistributeKey<T, Data>> { +public: + using KeyType = std::conditional_t<std::is_same_v<T, String>, UInt128, T>; + AggregateFunctionUniqDistributeKey(const DataTypes& argument_types_) + : IAggregateFunctionDataHelper<Data, AggregateFunctionUniqDistributeKey<T, Data>>( + argument_types_) {} + + String get_name() const override { return "uniqExactDistributeKey"; } Review Comment: multi_distinct_count_distribute_key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
