gavinchou commented on code in PR #33201:
URL: https://github.com/apache/doris/pull/33201#discussion_r1576224411
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##########
@@ -470,6 +470,10 @@ public Map<Long, Table> getIdToTableRef() {
return idToTable;
}
+ public List<Long> getTableIds() {
+ return new ArrayList<>(idToTable.keySet());
Review Comment:
Do we need to lock and make a copy of table ids here?
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SystemHandler.java:
##########
@@ -78,7 +78,9 @@ public SystemHandler() {
@Override
protected void runAfterCatalogReady() {
super.runAfterCatalogReady();
- runAlterJobV2();
+ if (Config.isNotCloudMode()) {
+ runAlterJobV2();
Review Comment:
Why? Pls dd a comment if there is a specific reason
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2721,7 +2721,7 @@ public static boolean isNotCloudMode() {
public static int cloud_min_balance_tablet_num_per_run = 2;
@ConfField(mutable = true, masterOnly = true)
- public static boolean cloud_preheating_enabled = false;
+ public static boolean cloud_preheating_enabled = true;
Review Comment:
Unify naming to xxx_warm_up_xxx.
e.g. enable_warm_up_for_rebalance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
