gavinchou commented on code in PR #33974:
URL: https://github.com/apache/doris/pull/33974#discussion_r1576652017
##########
be/src/runtime/exec_env_init.cpp:
##########
@@ -142,6 +142,15 @@ static void init_doris_metrics(const
std::vector<StorePath>& store_paths) {
DorisMetrics::instance()->initialize(init_system_metrics, disk_devices,
network_interfaces);
}
+// Used to calculate the num of min thread and max thread based on the passed
config
+static pair<size_t, size_t> get_num_threads(size_t min_num, size_t max_num) {
+ auto num_cores = doris::CpuInfo::num_cores();
+ auto factor = max_num / min_num;
Review Comment:
is it buggy if the max or min is zero?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
