github-actions[bot] commented on code in PR #34089:
URL: https://github.com/apache/doris/pull/34089#discussion_r1577975901
##########
be/src/service/point_query_executor.h:
##########
@@ -93,6 +95,12 @@
int64_t mem_size() const;
+ int32_t rs_column_uid() const { return _rs_column_uid; }
+
+ const std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
+
+ const std::unordered_set<int32_t> include_col_uids() const { return
_include_col_uids; }
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::unordered_set<int32_t> include_col_uids() const { return
_include_col_uids; }
```
##########
be/src/service/point_query_executor.h:
##########
@@ -93,6 +95,12 @@ class Reusable {
int64_t mem_size() const;
+ int32_t rs_column_uid() const { return _rs_column_uid; }
+
+ const std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
Review Comment:
warning: return type 'const int' is 'const'-qualified at the top level,
which may reduce code readability without improving const correctness
[readability-const-return-type]
```suggestion
std::unordered_set<int32_t> missing_col_uids() const { return
_missing_col_uids; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
