morrySnow commented on code in PR #34025:
URL: https://github.com/apache/doris/pull/34025#discussion_r1577973039
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -65,6 +65,9 @@ statementBase
(COMMENT STRING_LITERAL)? AS query
#createView
| ALTER VIEW name=multipartIdentifier (LEFT_PAREN cols=simpleColumnDefs
RIGHT_PAREN)?
AS query
#alterView
+ | CREATE (EXTERNAL)? TABLE (IF NOT EXISTS)? name=multipartIdentifier
+ LIKE existedTable=multipartIdentifier
+ ((WITH ROLLUP) (rollupNames=identifierList)?)? #createTableLike
Review Comment:
nit:
```suggestion
(WITH ROLLUP (rollupNames=identifierList)?)? #createTableLike
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertOverwriteTableCommand.java:
##########
@@ -115,7 +115,6 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
LogicalPlanAdapter logicalPlanAdapter = new
LogicalPlanAdapter(logicalQuery, ctx.getStatementContext());
NereidsPlanner planner = new NereidsPlanner(ctx.getStatementContext());
planner.plan(logicalPlanAdapter, ctx.getSessionVariable().toThrift());
- executor.checkBlockRules();
Review Comment:
why remove this? and execute it before command run? i think we could not do
right block before plan, since block run need check scan cardinality, tablet
num and partition num
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
