gavinchou commented on code in PR #34087:
URL: https://github.com/apache/doris/pull/34087#discussion_r1578080205
##########
be/src/io/fs/s3_file_reader.cpp:
##########
@@ -43,6 +44,9 @@ bvar::Adder<uint64_t>
s3_file_reader_read_counter("s3_file_reader", "read_at");
bvar::Adder<uint64_t> s3_file_reader_total("s3_file_reader", "total_num");
bvar::Adder<uint64_t> s3_bytes_read_total("s3_file_reader", "bytes_read");
bvar::Adder<uint64_t> s3_file_being_read("s3_file_reader", "file_being_read");
+bvar::LatencyRecorder s3_bytes_per_read("s3_file_reader", "bytes_per_read");
// also QPS
Review Comment:
It seems calculating the rate of s3_bytes_read_total (throughput) and
s3_file_reader_read_counter (qps), by grafana, will do the work.
Adding redundant metrics is a burden for the scraping procedure (Prometheus).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
