github-actions[bot] commented on code in PR #34142:
URL: https://github.com/apache/doris/pull/34142#discussion_r1579549430
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -262,11 +264,44 @@ Status CloudStorageEngine::start_bg_threads() {
RETURN_IF_ERROR(Thread::create(
"StorageEngine", "lease_compaction_thread",
[this]() { this->_lease_compaction_thread_callback(); },
&_bg_threads.emplace_back()));
+
+ if (config::file_cache_ttl_valid_check_interval_second != 0) {
+ RETURN_IF_ERROR(Thread::create(
+ "StorageEngine", "check_file_cache_ttl_block_valid_thread",
+ [this]() { this->_check_file_cache_ttl_block_valid(); },
+ &_bg_threads.emplace_back()));
+ LOG(INFO) << "check file cache ttl block valid thread started";
+ }
+
LOG(INFO) << "lease compaction thread started";
return Status::OK();
}
+void CloudStorageEngine::_check_file_cache_ttl_block_valid() {
+ int64_t interval_seconds =
config::file_cache_ttl_valid_check_interval_second / 2;
+ auto check_ttl = [](const std::weak_ptr<CloudTablet>& tablet_wk) {
+ auto tablet = tablet_wk.lock();
+ if (!tablet) return;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (!tablet) { return;
}
```
##########
be/test/io/cache/block_file_cache_test.cpp:
##########
@@ -3646,4 +3646,68 @@ TEST_F(BlockFileCacheTest,
remove_if_cached_when_isnt_releasable) {
ASSERT_TRUE(blocks[0]->finalize().ok());
}
+TEST_F(BlockFileCacheTest, recyle_unvalid_ttl_async) {
+ config::file_cache_ttl_valid_check_interval_second = 4;
+ if (fs::exists(cache_base_path)) {
+ fs::remove_all(cache_base_path);
+ }
+ fs::create_directories(cache_base_path);
+ TUniqueId query_id;
+ query_id.hi = 1;
+ query_id.lo = 1;
+ io::FileCacheSettings settings;
+ settings.query_queue_size = 30;
+ settings.query_queue_elements = 5;
+ settings.index_queue_size = 30;
+ settings.index_queue_elements = 5;
+ settings.disposable_queue_size = 30;
+ settings.disposable_queue_elements = 5;
+ settings.capacity = 90;
+ settings.max_file_block_size = 30;
+ settings.max_query_cache_size = 30;
+ io::CacheContext context;
+ context.query_id = query_id;
+ auto key = io::BlockFileCache::hash("key1");
+ io::BlockFileCache cache(cache_base_path, settings);
+ context.cache_type = io::FileCacheType::TTL;
+ context.expiration_time = UnixSeconds() + 3600;
+ auto sp = SyncPoint::get_instance();
Review Comment:
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
```suggestion
00;auto *
```
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -262,11 +264,44 @@
RETURN_IF_ERROR(Thread::create(
"StorageEngine", "lease_compaction_thread",
[this]() { this->_lease_compaction_thread_callback(); },
&_bg_threads.emplace_back()));
+
+ if (config::file_cache_ttl_valid_check_interval_second != 0) {
+ RETURN_IF_ERROR(Thread::create(
+ "StorageEngine", "check_file_cache_ttl_block_valid_thread",
+ [this]() { this->_check_file_cache_ttl_block_valid(); },
+ &_bg_threads.emplace_back()));
+ LOG(INFO) << "check file cache ttl block valid thread started";
+ }
+
LOG(INFO) << "lease compaction thread started";
return Status::OK();
}
+void CloudStorageEngine::_check_file_cache_ttl_block_valid() {
+ int64_t interval_seconds =
config::file_cache_ttl_valid_check_interval_second / 2;
+ auto check_ttl = [](const std::weak_ptr<CloudTablet>& tablet_wk) {
+ auto tablet = tablet_wk.lock();
+ if (!tablet) return;
+ if (tablet->tablet_meta()->ttl_seconds() == 0) return;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (tablet->tablet_meta()->ttl_seconds() == 0) { return;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
