yiguolei commented on code in PR #34145:
URL: https://github.com/apache/doris/pull/34145#discussion_r1579823971
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -465,6 +466,13 @@ class PipelineXSpillLocalState : public
PipelineXLocalState<SharedStateArg> {
return Status::OK();
}
+ void close_spill() {
+ // release memory fast
+ _spill_task.reset();
+ }
+
+ std::shared_ptr<vectorized::SpillTask> _spill_task;
Review Comment:
Do not add this to operator. Because not all operator need spill task.
Operator should be very very abstract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
