This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 0d374478b6b [branch-2.0](cherry-pick) Not add disk path to broken list
if check status is not IO_ERROR (#34111) (#34144)
0d374478b6b is described below
commit 0d374478b6bc84c595a019b77764bd2dd9bec2a7
Author: zxealous <[email protected]>
AuthorDate: Fri Apr 26 21:42:30 2024 +0800
[branch-2.0](cherry-pick) Not add disk path to broken list if check status
is not IO_ERROR (#34111) (#34144)
---
be/src/olap/data_dir.cpp | 2 +-
be/src/service/doris_main.cpp | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/be/src/olap/data_dir.cpp b/be/src/olap/data_dir.cpp
index 985eea3d914..f41b2894389 100644
--- a/be/src/olap/data_dir.cpp
+++ b/be/src/olap/data_dir.cpp
@@ -236,7 +236,7 @@ void DataDir::health_check() {
// check disk
if (_is_used) {
Status res = _read_and_write_test_file();
- if (!res) {
+ if (!res && res.is<IO_ERROR>()) {
LOG(WARNING) << "store read/write test file occur IO Error. path="
<< _path
<< ", err: " << res;
StorageEngine::instance()->add_broken_path(_path);
diff --git a/be/src/service/doris_main.cpp b/be/src/service/doris_main.cpp
index 1a9c0d5102e..19259b5e3da 100644
--- a/be/src/service/doris_main.cpp
+++ b/be/src/service/doris_main.cpp
@@ -373,6 +373,7 @@ int main(int argc, char** argv) {
it = paths.erase(it);
} else {
LOG(ERROR) << "read write test file failed, path=" << it->path;
+ // if only one disk and the disk is full, also need exit
because rocksdb will open failed
exit(-1);
}
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
