dataroaring commented on code in PR #28082:
URL: https://github.com/apache/doris/pull/28082#discussion_r1581150129
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/ReplicasProcNode.java:
##########
@@ -44,7 +44,7 @@ public class ReplicasProcNode implements ProcNodeInterface {
.add("BackendId").add("Version").add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
.add("SchemaHash").add("LocalDataSize").add("RemoteDataSize").add("RowCount").add("State").add("IsBad")
.add("IsUserDrop")
- .add("VersionCount").add("PathHash").add("Path")
+
.add("VisibleVersionCount").add("TotalVersionCount").add("PathHash").add("Path")
Review Comment:
We should not change name known by users, there may be some tools on it.
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/TabletsProcDir.java:
##########
@@ -52,9 +52,10 @@ public class TabletsProcDir implements ProcDirInterface {
.add("LstSuccessVersion").add("LstFailedVersion").add("LstFailedTime")
.add("LocalDataSize").add("RemoteDataSize").add("RowCount").add("State")
.add("LstConsistencyCheckTime").add("CheckVersion")
- .add("VersionCount").add("QueryHits").add("PathHash").add("Path")
+
.add("VisibleVersionCount").add("TotalVersionCount").add("QueryHits").add("PathHash").add("Path")
Review Comment:
We should not change name already exposed to user.
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/PublishVersionDaemon.java:
##########
@@ -60,14 +61,18 @@ public PublishVersionDaemon() {
@Override
protected void runAfterCatalogReady() {
+ Map<Long, Long> partitionVisibleVersions = Maps.newHashMap();
+ Map<Long, Set<Long>> backendPartitions = Maps.newHashMap();
+
try {
- publishVersion();
+ publishVersion(partitionVisibleVersions, backendPartitions);
+ sendBackendVisibleVersion(partitionVisibleVersions,
backendPartitions);
Review Comment:
If report handles it, we should skip send here. We can pack visible version
in publish request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
