github-actions[bot] commented on code in PR #34137:
URL: https://github.com/apache/doris/pull/34137#discussion_r1581997094
##########
be/src/io/cache/block_file_cache_factory.cpp:
##########
@@ -80,18 +80,23 @@ Status FileCacheFactory::create_file_cache(const
std::string& cache_base_path,
LOG_ERROR("").tag("file cache path", cache_base_path).tag("error",
strerror(errno));
return Status::IOError("{} statfs error {}", cache_base_path,
strerror(errno));
}
- size_t disk_total_size = static_cast<size_t>(stat.f_blocks) *
static_cast<size_t>(stat.f_bsize);
- if (disk_total_size < file_cache_settings.capacity) {
- file_cache_settings = get_file_cache_settings(size_t(disk_total_size *
0.9),
-
file_cache_settings.max_query_cache_size);
+ size_t disk_capacity = static_cast<size_t>(
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto disk_capacity = static_cast<size_t>(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
