englefly commented on code in PR #34169:
URL: https://github.com/apache/doris/pull/34169#discussion_r1581999179


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/hint/LeadingHint.java:
##########
@@ -124,6 +124,32 @@ public LeadingHint(String hintName, List<String> 
parameters, String originalStri
             }
             lastParameter = parameter;
         }
+        normalizeLevelList();
+    }
+
+    private void removeGap(int left, int right, int gap) {
+        for (int i = left; i <= right; i++) {
+            levellist.set(i, levellist.get(i) - (gap - 1));
+        }
+    }
+
+    // when leading extract levellist like 0 2 2 3 3 0, it could be reduced to 
0 1 1 2 2 0

Review Comment:
   please define what is the “gap”
   it is better to copy the example in "Proposed Change" to illustrate the 
concept of gap



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to