morningman commented on a change in pull request #7670:
URL: https://github.com/apache/incubator-doris/pull/7670#discussion_r780636918
##########
File path: be/src/olap/row_block2.cpp
##########
@@ -170,6 +170,24 @@ void RowBlockV2::_copy_data_to_column(int cid,
doris::vectorized::MutableColumnP
}
break;
}
+ case OLAP_FIELD_TYPE_STRING: {
+ auto column_string = assert_cast<vectorized::ColumnString*>(column);
+
+ for (uint16_t j = 0; j < _selected_size; ++j) {
+ if (!nullable_mark_array[j]) {
+ uint16_t row_idx = _selection_vector[j];
+ auto slice = reinterpret_cast<const
Slice*>(column_block(cid).cell_ptr(row_idx));
+ if (LIKELY(slice->size <= 1024 * 1024)) {
Review comment:
Define a variable for `1024 * 1024`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
