morningman commented on code in PR #32980:
URL: https://github.com/apache/doris/pull/32980#discussion_r1589872449
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionEntry.java:
##########
@@ -261,22 +278,62 @@ public long abortTransaction()
}
}
+ private void beforeFinishTransaction() {
+ if (isTransactionBegan) {
+ List<Long> tableIds =
transactionState.getTableIdList().stream().distinct().collect(Collectors.toList());
+ transactionState.setTableIdList(tableIds);
+ subTransactionStates.sort((s1, s2) -> {
+ if (s1.getSubTransactionType() == SubTransactionType.INSERT
Review Comment:
Why using this order?
##########
fe/fe-core/src/main/java/org/apache/doris/load/EtlStatus.java:
##########
@@ -34,10 +35,13 @@
public class EtlStatus implements Writable {
public static final String DEFAULT_TRACKING_URL = FeConstants.null_string;
-
+ @SerializedName(value = "state")
private TEtlState state;
+ @SerializedName(value = "trackingUrl")
Review Comment:
use short name to reduce the edit log size, eg: `tu
Same comment for all other SerializedName
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -243,6 +245,22 @@ public void commitTransaction(long dbId, List<Table>
tableList, long transaction
dbTransactionMgr.commitTransaction(tableList, transactionId,
tabletCommitInfos, txnCommitAttachment, false);
}
+ /**
+ * @note callers should get all tables' write locks before call this api
+ */
+ public void commitTransaction(long dbId, List<Table> tableList, long
transactionId,
Review Comment:
the timeout is unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
