zhiqiang-hhhh commented on code in PR #34391:
URL: https://github.com/apache/doris/pull/34391#discussion_r1590792224
##########
be/src/vec/functions/round.h:
##########
@@ -630,9 +630,9 @@ struct Dispatcher {
return col_res;
} else {
- throw doris::Exception(ErrorCode::INVALID_ARGUMENT,
- "Unsupported column {} for function
truncate",
- const_col_general->get_name());
+ LOG(FATAL) << "__builtin_unreachable";
Review Comment:
Actually I prefer using Exception instead of `LOG(FATAL)`, because we have
no reason to explicitly make BE crash unless this logical error will lead to
data incomplete or other problem worse than cluster shut down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
