morrySnow commented on code in PR #34418:
URL: https://github.com/apache/doris/pull/34418#discussion_r1590987183
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertIntoTableCommand.java:
##########
@@ -162,6 +163,9 @@ public AbstractInsertExecutor initPlan(ConnectContext ctx,
StmtExecutor executor
// return;
throw new AnalysisException("group commit is not supported
in Nereids now");
}
+ if (physicalSink.child(0) instanceof PhysicalEmptyRelation) {
+ return null;
Review Comment:
use Optional<AbstractInsertExecutor> as return type and add more comment to
explain what if return is empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
