morrySnow commented on code in PR #34455:
URL: https://github.com/apache/doris/pull/34455#discussion_r1591751397
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalDatabase.java:
##########
@@ -283,6 +283,16 @@ public DatabaseProperty getDbProperties() {
return dbProperties;
}
+ @Override
+ public String getDbComment() {
+ throw new NotImplementedException("getDbComment() is not implemented");
Review Comment:
return empty string is better?
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##########
@@ -676,6 +700,7 @@ public void readFields(DataInput in) throws IOException {
Text.readString(in);
dbState = DbState.valueOf(Text.readString(in));
attachDbName = Text.readString(in);
+ dbComment = Text.readString(in);
Review Comment:
read comment only if version >= 132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
