morrySnow commented on code in PR #34473:
URL: https://github.com/apache/doris/pull/34473#discussion_r1592421793
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/ComputePrecisionForRound.java:
##########
@@ -37,7 +37,8 @@ default FunctionSignature computePrecision(FunctionSignature
signature) {
Expression floatLength = getArgument(1);
int scale;
- if (floatLength.isLiteral() || (floatLength instanceof Cast &&
floatLength.child(0).isLiteral()
+ if ((floatLength.isLiteral() && floatLength.getDataType()
instanceof Int32OrLessType)
Review Comment:
when we do computePrecision, we do not finish compute signature. so type
coercion do not apply. so its child could be any type literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
