This is an automated email from the ASF dual-hosted git repository.

kxiao pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
     new 6dfc8576dd4 [opt](inverted index)Modify the parameter passing method 
for compound list (#34476)
6dfc8576dd4 is described below

commit 6dfc8576dd49a9544b4af2dc6b66b17e7bc925c1
Author: zzzxl <[email protected]>
AuthorDate: Wed May 8 10:17:55 2024 +0800

    [opt](inverted index)Modify the parameter passing method for compound list 
(#34476)
---
 be/src/exec/olap_utils.h                           | 4 ++--
 be/src/olap/rowset/segment_v2/segment_iterator.cpp | 7 +++----
 be/src/vec/exec/scan/vscan_node.cpp                | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/be/src/exec/olap_utils.h b/be/src/exec/olap_utils.h
index abe5e45cb9f..551e1c47461 100644
--- a/be/src/exec/olap_utils.h
+++ b/be/src/exec/olap_utils.h
@@ -155,9 +155,9 @@ inline SQLFilterOp to_olap_filter_type(const std::string& 
function_name, bool op
     } else if (function_name == "ne") {
         return opposite ? FILTER_IN : FILTER_NOT_IN;
     } else if (function_name == "in_list") {
-        return opposite ? FILTER_IN : FILTER_NOT_IN;
-    } else if (function_name == "not_in_list") {
         return opposite ? FILTER_NOT_IN : FILTER_IN;
+    } else if (function_name == "not_in_list") {
+        return opposite ? FILTER_IN : FILTER_NOT_IN;
     } else {
         DCHECK(false) << "Function Name: " << function_name;
         return FILTER_IN;
diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp 
b/be/src/olap/rowset/segment_v2/segment_iterator.cpp
index 920c6eb17fb..342d77ae0bb 100644
--- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp
@@ -916,8 +916,8 @@ std::string 
SegmentIterator::_gen_predicate_result_sign(ColumnPredicate* predica
     auto pred_type = predicate->type();
     auto predicate_params = predicate->predicate_params();
     pred_result_sign = BeConsts::BLOCK_TEMP_COLUMN_PREFIX + 
column_desc->name() + "_" +
-                       predicate->pred_type_string(pred_type) + "_";
-    pred_result_sign += join(predicate_params->values, ",");
+                       predicate->pred_type_string(pred_type) + "_" +
+                       join(predicate_params->values, ",");
 
     return pred_result_sign;
 }
@@ -925,8 +925,7 @@ std::string 
SegmentIterator::_gen_predicate_result_sign(ColumnPredicate* predica
 std::string SegmentIterator::_gen_predicate_result_sign(ColumnPredicateInfo* 
predicate_info) {
     std::string pred_result_sign;
     pred_result_sign = BeConsts::BLOCK_TEMP_COLUMN_PREFIX + 
predicate_info->column_name + "_" +
-                       predicate_info->query_op + "_";
-    pred_result_sign += join(predicate_info->query_values, ",");
+                       predicate_info->query_op + "_" + 
join(predicate_info->query_values, ",");
     return pred_result_sign;
 }
 
diff --git a/be/src/vec/exec/scan/vscan_node.cpp 
b/be/src/vec/exec/scan/vscan_node.cpp
index 2e8390f08a7..ca2bf8ca77f 100644
--- a/be/src/vec/exec/scan/vscan_node.cpp
+++ b/be/src/vec/exec/scan/vscan_node.cpp
@@ -1154,7 +1154,7 @@ Status 
VScanNode::_normalize_in_and_not_in_compound_predicate(vectorized::VExpr*
             }
             auto value = const_cast<void*>(iter->get_value());
             RETURN_IF_ERROR(_change_value_range<false>(
-                    range, value, 
ColumnValueRange<T>::add_compound_value_range, fn_name));
+                    range, value, 
ColumnValueRange<T>::add_compound_value_range, fn_name, 0));
             iter->next();
         }
         *pdt = PushDownType::ACCEPTABLE;


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to