amosbird commented on a change in pull request #7712:
URL: https://github.com/apache/incubator-doris/pull/7712#discussion_r784078071
##########
File path: thirdparty/build-thirdparty.sh
##########
@@ -426,13 +444,14 @@ build_curl() {
check_if_source_exist $CURL_SOURCE
cd $TP_SOURCE_DIR/$CURL_SOURCE
- CPPFLAGS="-I${TP_INCLUDE_DIR}" \
- LDFLAGS="-L${TP_LIB_DIR}" LIBS="-lcrypto -lssl -lcrypto -ldl" \
+ CPPFLAGS="-I${TP_INCLUDE_DIR} -DNGHTTP2_STATICLIB" \
+ LDFLAGS="-L${TP_LIB_DIR}" LIBS="-lcrypto -lssl -lcrypto -ldl -static" \
CFLAGS="-fPIC" \
+ PKG_CONFIG="pkg-config --static" \
./configure --prefix=$TP_INSTALL_DIR --disable-shared --enable-static \
--without-librtmp --with-ssl=${TP_INSTALL_DIR} --without-libidn2
--disable-ldap --enable-ipv6 \
- --without-libssh2
- make -j $PARALLEL && make install
+ --without-libssh2 --without-brotli
Review comment:
I think we can refine the thirdparty builds gradually in subsequent PRs.
After we encourage hermetic build, there will be a broad range of environment
for testing. Corner cases are definitely expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
