seawinde commented on code in PR #34274:
URL: https://github.com/apache/doris/pull/34274#discussion_r1595090968
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewAggregateRule.java:
##########
@@ -426,7 +447,8 @@ private Pair<Set<? extends Expression>, Set<? extends
Expression>> topPlanSplitT
topGroupByExpressions.add(expression);
}
});
- return Pair.of(topGroupByExpressions, topFunctionExpressions);
+ groupByExpressionSet.removeAll(topGroupByExpressions);
Review Comment:
`topPlanSplitToGroupAndFunction` means get the group by and agg fuctions
expression pair from top plan, this change the measing of the method
May be we can get the result of method `topPlanSplitToGroupAndFunction` and
then do your removeAll logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
