morrySnow commented on code in PR #34681:
URL: https://github.com/apache/doris/pull/34681#discussion_r1597396449
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java:
##########
@@ -59,41 +60,46 @@ public class UnboundRelation extends LogicalRelation
implements Unbound, BlockFu
// the start and end position of the sql substring(e.g. "t1", "db1.t1",
"ctl1.db1.t1")
private final Optional<Pair<Integer, Integer>> indexInSqlString;
+ private final TableSnapshot tableSnapshot;
Review Comment:
```suggestion
private final Optional<TableSnapshot> tableSnapshot;
```
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -966,6 +966,10 @@ sampleMethod
| INTEGER_VALUE ROWS
#sampleByRows
;
+tableSnapshot
+ : FOR tableSnapshotType=(TIME | VERSION) AS OF valueExpression
Review Comment:
valueExpression is a big scope, such as a + b. If only need number literal,
please use `number`. if also need string literal, please use `number |
STRING_LITERAL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
