HappenLee commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1597853085
##########
be/src/vec/sink/writer/vtablet_writer.cpp:
##########
@@ -359,22 +357,23 @@ Status VNodeChannel::init(RuntimeState* state) {
// add block closure
// Has to using value to capture _task_exec_ctx because tablet writer may
destroyed during callback.
_send_block_callback =
WriteBlockCallback<PTabletWriterAddBlockResult>::create_shared();
- _send_block_callback->addFailedHandler([&, task_exec_ctx =
_task_exec_ctx](bool is_last_rpc) {
- auto ctx_lock = task_exec_ctx.lock();
- if (ctx_lock == nullptr) {
- return;
- }
- _add_block_failed_callback(is_last_rpc);
- });
+ _send_block_callback->addFailedHandler(
+ [&, task_exec_ctx = _task_exec_ctx](bool is_last_rpc, bool
first_stage_close) {
Review Comment:
move `first_stage_close` to exec_ctx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
