morningman commented on a change in pull request #7818:
URL: https://github.com/apache/incubator-doris/pull/7818#discussion_r788778279
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/PaloAuth.java
##########
@@ -1026,13 +1036,15 @@ public void setPasswordInternal(UserIdentity userIdent,
byte[] password, UserIde
// set ldap admin password.
public void setLdapPassword(SetLdapPassVar stmt) {
- LdapClient.init(stmt.getLdapPassword());
- LdapInfo info = new LdapInfo(stmt.getLdapPassword());
- Catalog.getCurrentCatalog().getEditLog().logSetLdapPassword(info);
+ ldapInfo = new LdapInfo(stmt.getLdapPassword());
Review comment:
I think we need lock to protect the `ldapInfo`?
##########
File path:
fe/fe-core/src/main/java/org/apache/doris/common/util/SymmetricEncryption.java
##########
@@ -17,58 +17,69 @@
package org.apache.doris.common.util;
-import java.io.UnsupportedEncodingException;
+import com.google.common.base.Strings;
Review comment:
import order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
